riscv/bl602: Remove check for LCD driver#5907
Merged
gustavonihei merged 1 commit intoapache:masterfrom Mar 30, 2022
Merged
Conversation
## Summary `bl602_spi_cmddata()` implements SPI Cmd/Data `SPI_CMDDATA()` for only 3 LCD drivers: ST7735, ST7789 and GC9A01. This patch removes the check for LCD drivers, so that SPI Cmd/Data will work for all LCD drivers. More details: apache#5898 ## Impact This change impacts LCD drivers that call `SPI_CMDDATA()`. Previously `SPI_CMDDATA()` would fail with `ENODEV` for LCD drivers other than ST7735, ST7789 and GC9A01. After patching, `SPI_CMDDATA()` will work correctly with all LCD drivers. ## Testing We tested with LVGL and ST7789 on PineCone BL602: - [Testing with LVGL](https://github.com/lupyuen/st7789-nuttx#run-lvgl-demo) As for regular SPI Devices that don't require SPI Cmd/Data, we tested `CONFIG_SPI_CMDDATA=y` with Semtech SX1262 SPI Transceiver on PineCone BL602: - [Testing Cmd/Data](https://github.com/lupyuen/incubator-nuttx/releases/tag/release-2022-03-30)
gustavonihei
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bl602_spi_cmddata()implements SPI Cmd/DataSPI_CMDDATA()for only 3 LCD drivers: ST7735, ST7789 and GC9A01.This patch removes the check for LCD drivers, so that SPI Cmd/Data will work for all LCD drivers.
More details: #5898
Impact
This change impacts LCD drivers that call
SPI_CMDDATA().Previously
SPI_CMDDATA()would fail withENODEVfor LCD drivers other than ST7735, ST7789 and GC9A01.After patching,
SPI_CMDDATA()will work correctly with all LCD drivers.Testing
We tested with LVGL and ST7789 on PineCone BL602:
As for regular SPI Devices that don't require SPI Cmd/Data, we tested
CONFIG_SPI_CMDDATA=ywith Semtech SX1262 SPI Transceiver on PineCone BL602: