lsp.client: Fix breadcrumb rendering#9116
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Jan 7, 2026
Merged
Conversation
After the document symbols are collected, they also need to be added to the result list. Before this change the result was ignored.
Contributor
Author
|
I intent to merge this by the end of the week. If anyone wants to object, please do so now. |
lahodaj
approved these changes
Jan 7, 2026
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! (And sorry for belated reply.)
Contributor
Author
|
@lahodaj thanks and no worries 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the document symbols are collected, they also need to be added to the result list. Before this change the result was ignored. This results in an empty breadcrumb list or a breadcrumb list only containing the file entry.
This is an artifact of the support for multiple LSP servers for a single document (2bd5ac3)