Merged
Conversation
Contributor
|
There are some Applet references in the functional tests of Those shall be attended to as well (I'm bit unsure of the |
- updated already deprecated InstanceSupport.isApplet() to return false and fixed some warnings - removed unused applet templates - updated FXSwingMain template - removed usage in qa tests
66bacaf to
bcb9a6e
Compare
Member
Author
|
yeah you are right, I removed some more usage. I am used to skip tests during refactoring (esp those which don't run) to keep changesets smaller. Whats left are the ant files of the qa tests and there is a JavaFX sample application I couldn't find anywhere in the UI which I kept as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstanceSupport.isApplet()to returnfalseand fixed some warningsoverlooked an
instanceofcall in #9019