Skip to content

Fix for issue 9018: Javadoc viewer shows HTML comments#9071

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
makiam:html-comment-tag-fix
Dec 6, 2025
Merged

Fix for issue 9018: Javadoc viewer shows HTML comments#9071
matthiasblaesing merged 1 commit intoapache:masterfrom
makiam:html-comment-tag-fix

Conversation

@makiam
Copy link
Contributor

@makiam makiam commented Dec 6, 2025

Fix for #9018

Given html tag passed to default section of inlineTags method and thus changes opening bracket convered to 'lt' entity
I add extra case 'COMMENT' to bupass this DocTree tag processing

Add test to check this


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Signed-off-by: Maksim Khramov <maxtemplaar@gmail.com>
@matthiasblaesing matthiasblaesing added JavaDoc [ci] enable java/javadoc tests and build-javadoc target ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 6, 2025
@matthiasblaesing matthiasblaesing added this to the NB29 milestone Dec 6, 2025
@apache apache locked and limited conversation to collaborators Dec 6, 2025
@apache apache unlocked this conversation Dec 6, 2025
@matthiasblaesing matthiasblaesing added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) and removed JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Dec 6, 2025
@apache apache locked and limited conversation to collaborators Dec 6, 2025
@apache apache unlocked this conversation Dec 6, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you!

@matthiasblaesing matthiasblaesing merged commit 7d7925b into apache:master Dec 6, 2025
93 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants