Fixes jflex coloring display for macro values splitted on multiple new lines#9063
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Dec 6, 2025
Conversation
The solution for exiting the antlr macro value state is to search for a letter or a '%' char when consuming new lines + whitespace tokens. Pipe operator in jflex rule definitions is marked as regex. Added template description for jflex. Unit tests for the coloring lexer updates.
matthiasblaesing
approved these changes
Dec 6, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the display for macro values splitted on multiple lines.
I discovered it on the latte jflex file.
I also thought that the pipe operator is better displayed under regex the coloring definition.
The pull request also adds a template description on the new file wizard form.