Merged
Conversation
Member
Author
|
the (unrelated) refactoring generates: private final transient_or_acc_varargs PropertyChangeSupport propertyChangeSupport = new java.beans.PropertyChangeSupport(this);instead of: private final transient PropertyChangeSupport propertyChangeSupport = new java.beans.PropertyChangeSupport(this);sounds like a change in a edit: fixed |
lahodaj
reviewed
Nov 28, 2025
....editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
Outdated
Show resolved
Hide resolved
mbien
commented
Dec 1, 2025
This was referenced Dec 2, 2025
lahodaj
approved these changes
Dec 11, 2025
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
- switched to FlagsEnum and updated other internal API usages - updated tests where needed - CI: add 26-ea to hava-hints matrix Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the javac integration to nb-javac based on JDK 26b27.
This PR is based on a copy of the valhalla javac experiment #8995 but swaps the nb-javac dependency against staged nb-javac 26b26 based on https://github.com/lahodaj/nb-javac/commits/upgrade-jdk26/.
It will be later updated to a nb-javac release from maven central.donemanual testing:
closes #4470
closes #6822
closes #8722