Round the completion item text width correctly#9032
Merged
mbien merged 1 commit intoapache:masterfrom Nov 22, 2025
Merged
Conversation
Text does sometimes not fit into the computed bounds of the completion item using certain fonts. Store the width as double and round the sum up to the nearest int.
neilcsmith-net
approved these changes
Nov 22, 2025
Member
neilcsmith-net
left a comment
There was a problem hiding this comment.
So, not just one rounding down error, but multiple!
Looks good at glance. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text does sometimes not fit into the computed bounds of the completion item using certain fonts.
Store the width as double and round the sum up to the nearest int.
before:
after:
font: Source Code Pro Medium 13