Merged
Conversation
Member
Author
|
I thought I tested the build post applet removal #8576 (comment) :( edit: extracted to #9019 |
This was referenced Nov 15, 2025
mbien
commented
Nov 16, 2025
Comment on lines
-465
to
+470
| } catch (ThreadDeath td) { | ||
| LOG.log(Level.FINE, "Received ThreadDeath, killed: {0}", killed); | ||
| if (!killed.get()) { | ||
| throw td; | ||
| } | ||
| // TODO this code relied on performStop() calling Thread.stop() | ||
| // } catch (ThreadDeath td) { | ||
| // LOG.log(Level.FINE, "Received ThreadDeath, killed: {0}", killed); | ||
| // if (!killed.get()) { | ||
| // throw td; | ||
| // } |
Member
Author
There was a problem hiding this comment.
I wasn't able to reach this code path. But I also don't really know all usecases of the jshell integration, outside of opening it via the tools menu.
But since nobody complained about UnsupportedOperationExceptions so far, it might be very niche or not reachable anymore at this point.
bumps upper bound to 26-ea typical matrix will be: - [17, 25, 26-ea] for PRs - [17, 26-ea] for master exceptions: - build-tools which tests on 21 since some tests don't run on 25 - java tests have to wait for nb-javac 26
Member
Author
|
will merge once green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumps upper bound to 26-ea
typical matrix will be:
[17, 25, 26-ea]for PRs[17, 26-ea]for masterexceptions:
closes #4952 (second commit removes last remaining Thread.stop() usage in the jshell module)