Enable parsing of JSP 3.0 (Jakarta) based sources#8976
Merged
matthiasblaesing merged 4 commits intoapache:masterfrom Nov 12, 2025
Merged
Enable parsing of JSP 3.0 (Jakarta) based sources#8976matthiasblaesing merged 4 commits intoapache:masterfrom
matthiasblaesing merged 4 commits intoapache:masterfrom
Conversation
69810c7 to
fc6d9d9
Compare
mbien
reviewed
Nov 6, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
left a few comments/questions while looking through it, nothing important though
enterprise/web.jspparser/extsrc/org/apache/jasper/compiler/GetParseData.java
Outdated
Show resolved
Hide resolved
enterprise/web.jspparser/extsrc/org/apache/jasper/compiler/GetParseData.java
Outdated
Show resolved
Hide resolved
enterprise/web.jspparser/src/org/netbeans/modules/web/jsps/parserapi/TagAttributeInfo.java
Show resolved
Hide resolved
enterprise/web.jspparser/extsrc/org/apache/jasper/compiler/NodeConverterVisitor.java
Show resolved
Hide resolved
enterprise/web.jspparser/src/org/netbeans/modules/web/jsps/parserapi/Node.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mbien thanks for commenting. I pushed an update which address most of the comments. I did not change the implementation of the tag library info holders. The problem is, that the structure is circular ( |
mbien
approved these changes
Nov 8, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
looks good as far as I can tell. Seems to work as intended, although I did only basic testing.
89b1854 to
bc4b88f
Compare
JSP 2.X and 3.X could both be parsed by a 3.X compatible Parser. However Jasper (the JSP implementation of Apache Tomcat) has ties to the API and the parser thus has to match the target runtime environment. To solve this problem both a JSP 2.X (javax-Namespace) and a 3.X parser are built and switch based on the declared specification of the project. The servletjspapi module was enhanced to carry both the javax. and the jakarta. based API classes. These don't clash - just many (all?) implementations decided to not support deployment on the same classpath. Closes: apache#8543
bc4b88f to
6b042fb
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSP 2.X and 3.X could both be parsed by a 3.X compatible Parser. However Jasper (the JSP implementation of Apache Tomcat) has ties to the API and the parser thus has to match the target runtime environment.
To solve this problem both a JSP 2.X (javax-Namespace) and a 3.X parser are built and switch based on the declared specification of the project.
The servletjspapi module was enhanced to carry both the javax. and the jakarta. based API classes. These don't clash - just many (all?) implementations decided to not support deployment on the same classpath.
Closes: #8543