Highlight 'module' in 'import module' as keyword.#8975
Merged
lahodaj merged 1 commit intoapache:masterfrom Nov 4, 2025
Merged
Conversation
mbien
approved these changes
Oct 31, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
looks good.
I tried to do something similar for the value context sensitive keyword. But than I realized that javac would fail before even reaching the code path so it didn't work.
....editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
Outdated
Show resolved
Hide resolved
d9a70d8 to
446106b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title says it -
moduleinimport moduleshould be highlighted as a keyword.^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)