Prevent duplication of guard clause in switch expressions#8971
Merged
mbien merged 1 commit intoapache:masterfrom Nov 9, 2025
Merged
Prevent duplication of guard clause in switch expressions#8971mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
lahodaj
approved these changes
Nov 2, 2025
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
Makes sense to me (although the commit should probably be squashed&there should be a commit message along the lines of:
[8495] prevent duplication of guard clause in switch expressions
Member
|
this PR here would also need a proper commit message before integration. If I am allowed to push into the PR i could fix it to safe time. Setting NB 29 milestone to keep this PR on the radar. |
Member
|
going to rebase, update the commit msg and then merge once CI is green again |
mbien
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8495
This PR cleans up compare to the previous PR.
Implemented are the changes in CasualDiff and added test in SwitchTest as suggested by lahodaj
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)