Skip to content

Replaced codicons in Change Method refactoring UI with Unicode characters#8952

Merged
lahodaj merged 1 commit intoapache:masterfrom
Achal1607:fix-button-ui
Nov 6, 2025
Merged

Replaced codicons in Change Method refactoring UI with Unicode characters#8952
lahodaj merged 1 commit intoapache:masterfrom
Achal1607:fix-button-ui

Conversation

@Achal1607
Copy link
Collaborator

Codicons were removed in #4040, but ChangeMethodParameters.html still used them.
Since the VS Code extension doesn’t include codicon assets, the icons failed to load. It is only packaged as a dev-dependency.

Replaced Codicons with suitable Unicode symbols for consistent UI without extra dependencies.
New UI:

Screenshot 2025-10-24 at 7 40 59 PM

@Achal1607 Achal1607 changed the title replaced codicons from the change method refactoring UI Replaced codicons from the change method refactoring UI Oct 24, 2025
@Achal1607 Achal1607 changed the title Replaced codicons from the change method refactoring UI Replaced Codicons in Change Method refactoring UI with Unicode characters Oct 24, 2025
@Achal1607 Achal1607 changed the title Replaced Codicons in Change Method refactoring UI with Unicode characters Replaced codicons in Change Method refactoring UI with Unicode characters Oct 24, 2025
@Achal1607 Achal1607 requested review from dbalek and lahodaj October 24, 2025 14:26
@Achal1607 Achal1607 added LSP [ci] enable Language Server Protocol tests VSCode Extension labels Oct 24, 2025
@apache apache locked and limited conversation to collaborators Oct 24, 2025
@apache apache unlocked this conversation Oct 24, 2025
@mbien mbien added this to the NB29 milestone Oct 25, 2025
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, thanks!

@lahodaj lahodaj merged commit a29d0fc into apache:master Nov 6, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LSP [ci] enable Language Server Protocol tests VSCode Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants