Fixes most layer position warnings and improves logging#8916
Merged
mbien merged 1 commit intoapache:masterfrom Nov 18, 2025
Merged
Fixes most layer position warnings and improves logging#8916mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
mbien
commented
Oct 15, 2025
Comment on lines
-90
to
91
| @MimeRegistration(mimeType="", service=CompletionProvider.class) | ||
| @MimeRegistration(mimeType="", service=CompletionProvider.class, position = 1000) | ||
| public class CompletionProviderImpl implements CompletionProvider { |
Member
Author
There was a problem hiding this comment.
java completion provider is at 100, rest increments by 100 typically. Wasn't sure where to put the LSP provider. This would be at the end of the list. (I didn't check but I believe this is where items without position would land too)
Member
Author
There was a problem hiding this comment.
@jlahoda having no position is essentially end of the list, so I believe setting pos=1000 should be ok here?
the org-netbeans-modules-spellchecker-completion-WordCompletion did also have no position, which means the end of the list wasn't "well defined" for the completion providers I believe.
cfe70c4 to
d3e03cf
Compare
eirikbakke
reviewed
Oct 15, 2025
...ellchecker.bindings.htmlxml/src/org/netbeans/modules/spellchecker/bindings/htmlxml/layer.xml
Outdated
Show resolved
Hide resolved
d3e03cf to
5519192
Compare
eirikbakke
approved these changes
Nov 16, 2025
Contributor
eirikbakke
left a comment
There was a problem hiding this comment.
Looks fine, setting positions is unlikely to cause problems.
The warning message will now include the position of the services to make picking a value easier. Tested activation of all clusters and maven project creation, only one root '/' warning is left to fix in the log. Might make the layer behave more deterministic in some cases. conflict fixes: same position 300 for both UI/ToolActions/Files/org-netbeans-modules-diff-tree-RecursiveDiffAction.shadow and UI/ToolActions/Files/org-netbeans-modules-favorites-Add.shadow -> RecursiveDiffAction = 250 same position 650 for both Templates/Project/GradleGroovy and Templates/Project/Native Native -> 660 ordering fixes: Not all children in Windows2/Modes/output/ marked with the position attribute: [TextToolsTopComponent.wstcref], but some are: [watchesView.wstcref, NotificationCenterTopComponent.wstcref, ...] -> TextToolsTopComponent = 3400 Not all children in OptionsDialog/Editor/ marked with the position attribute: [InlineHints], but some are: [CodeCompletion, Formatting, Hints, MarkOccurrences, ...] -> InlineHints = 0 Not all children in Windows2/Modes/editor/ marked with the position attribute: [TreeDiffViewerTopComponent.wstcref, CoverageReportTopComponent.wstcref], but some are: [DashboardDisplayer.wstcref] -> CoverageReportTopComponent = 0 -> TreeDiffViewerTopComponent = 0 Not all children in Templates/Project/Maven2/ marked with the position attribute: [settings.xml], but some are: [JavaApp, org-netbeans-modules-maven-j2ee-ui-wizard-EEWizardIterator-createWebAppIterator, ...] -> settings.xml = 110 Not all children in / marked with the position attribute: [org-netbeans-modules-lsp-client-bindings-CompletionProviderImpl.instance], but some are: [org-netbeans-modules-editor-java-JavaCompletionProvider.instance, ...] -> CompletionProviderImpl = 1000 Not all children in / marked with the position attribute: [org-netbeans-modules-spellchecker-completion-WordCompletion.instance], but some are: [org-netbeans-modules-lsp-client-bindings-CompletionProviderImpl.instance@1000] -> WordCompletion = 600 (across several layer registrations) Not all children in Editors/text/x-java/CodeGenerators/ marked with the position attribute: [org-netbeans-modules-micronaut-db-MicronautDataEndpointGenerator$Factory.instance], but some are: [org-netbeans-modules-j2ee-ejbcore-ui-logicalview-ejb-action-AddMethodActions$AddBusinessMethodCodeGenerator.instance@10, ...] -> MicronautDataEndpointGenerator$Factory = 800 Not all children in / marked with the position attribute: [org-netbeans-modules-editor-java-JavaBracesMatcher.shadow], but some are: [org-netbeans-modules-editor-bracesmatching-LegacyEssMatcher.instance@100, org-netbeans-modules-editor-bracesmatching-DefaultMatcher.instance@200] -> JavaBracesMatcher = 300 Not all children in / marked with the position attribute: [org-netbeans-modules-xml-text-completion-XMLCompletionProvider.instance, org-netbeans-modules-xml-schema-completion-SchemaBasedCompletionProvider.instance], but some are: [org-netbeans-modules-spellchecker-completion-WordCompletion.instance@600, ...] -> XMLCompletionProvider = 700 -> SchemaBasedCompletionProvider = 800
Member
Author
|
going to rebase and merge. thanks for the review! |
5519192 to
aad44dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second round after #7235
bonus: The warning message will now include the position of the services to make picking a value easier.
Tested activation of all clusters and maven project creation, only one
org.openide.filesystems.Orderingroot '/' warning is left to fix in the log (which I avoided so far since it is a big one).Might make the layer behave more deterministic in some cases.
conflict fixes:
ordering fixes: