Set end position for implicit class declaration tree part of a compact source file #8856
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Nov 27, 2025
Conversation
lahodaj
reviewed
Oct 13, 2025
| switch(forTree.getKind()) { | ||
| case CLASS: | ||
| if ((int) target[1] >= 0 && (int) target[2] == -1) { | ||
| // Compact Source file (JEP 512) issue implicit class end position not found in code |
Contributor
There was a problem hiding this comment.
Suggested change
| // Compact Source file (JEP 512) issue implicit class end position not found in code | |
| // Compact Source file (JEP 512) issue implicit class end position not found in code | |
| // see JDK-8364015 |
…mpact source file compilation unit to end position of compilation unit tree.
96bf942 to
b59293f
Compare
Contributor
|
@shivam71 thanks for bringing this upstream. As this is reviewed, I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : End position not found for implicit class scaffolding compact source file (JEP 512)
Context
Debugging output for reference
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)