Fix performance scaling problem in JS-embedder annotation scanner#8423
Merged
mbien merged 1 commit intoapache:masterfrom Apr 15, 2025
Merged
Fix performance scaling problem in JS-embedder annotation scanner#8423mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
1 task
lahodaj
reviewed
Apr 15, 2025
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
The goal seems OK, although producing the TreePath cheaper might (and should) lead to similar performance effect, without resorting to play tricks with trees, with all complexity that brings.
Reduced scan time from 102s to 13ms for a synthetic test file containing 10k inner classes with Override annotations (no javascript).
864e0c2 to
ba7c010
Compare
lahodaj
approved these changes
Apr 15, 2025
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
This looks good, thanks!
Member
Author
|
awesome. Thanks again for the review! merging for NB 26. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced scan time from 102s to 13ms for a synthetic test file containing 10k inner classes with Override annotations (no javascript).
closes #8419