fix issue #8344 include css revert property#8404
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Apr 15, 2025
Merged
fix issue #8344 include css revert property#8404matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
There are test failures. My hint for the future, when you touch |
Contributor
|
Unittests are happy, change looks good. Please squash the changes into a single commit. When doing this, please adjust message of commit to a style similar to #8405. |
d133b75 to
2eb762c
Compare
Contributor
Author
Ah, sorry. |
Contributor
|
Thank you. At some point we need to improve the help display for these universal values, but at this point in time the approach is consistent and works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response of the issue #8344
Include the revert property in css property validator.
It is considered similar to "unset" so, it should be safe to add in the
ValueGrammarElement[]list.Before
After
This also required an update on the PropertyValueTest unit test.