Skip to content

JS: Support async generator methods (class { async * generator () { … })#8398

Merged
ebarboni merged 1 commit intoapache:masterfrom
matthiasblaesing:async-generator-class-method
Apr 16, 2025
Merged

JS: Support async generator methods (class { async * generator () { … })#8398
ebarboni merged 1 commit intoapache:masterfrom
matthiasblaesing:async-generator-class-method

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Contributor

Closes: #8397

@matthiasblaesing matthiasblaesing added JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Apr 6, 2025
@matthiasblaesing matthiasblaesing added this to the NB26 milestone Apr 6, 2025
…... }`)

Additional bugfix: async methods were potentially not correctly
recognized, leading to parser failures when encountering async-only
constructs.

Closes: apache#8397
@matthiasblaesing matthiasblaesing force-pushed the async-generator-class-method branch from 6c508c0 to 64683f6 Compare April 14, 2025 16:36
@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

I intent to merge this tomorrow.

@neilcsmith-net neilcsmith-net modified the milestones: NB26, NB27 Apr 16, 2025
@ebarboni
Copy link
Copy Markdown
Contributor

LGTM sorry forget to comment yesterday. Merging on NB 26

@ebarboni ebarboni modified the milestones: NB27, NB26 Apr 16, 2025
@ebarboni ebarboni merged commit 7a29441 into apache:master Apr 16, 2025
31 checks passed
@matthiasblaesing matthiasblaesing deleted the async-generator-class-method branch April 21, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

async *[Symbol.asyncIterator]() flagged as error

3 participants