include basic syntax coloring support for javascript vue files#8367
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
I made a first pass and left a few inline comments.
I'm correct, that this is only concerned with .vue files, aka single-file components?
Yes, exactly. |
|
Apart from the two remaining comments from yesterday, I forgot to add:
|
The timing related to branch points has nothing to do with the problematic aspects of this. The problem occurs if there's a need to revert any feature during branch. That discussion is for another place - personally I'd prefer no spec change in any feature PR, but not stopping it. The other thing to consider looking at this, but also probably not to resolve here, is that the number of friend dependencies in |
Ah, yes, my bad, I got inspired from "jade" implementation, and I included |
abd9aa8 to
c65b02d
Compare
|
@haidubogdan awesome!!! Thx for this great enhancement. I would like to suggest some more things for this MVP.
|
Sure, I will give it a try. |
|
@haidubogdan this looks good to me. Of course more could be done, but I suggest to ensure this gets in and is not lost in the quest to do more. Would you please squash the commits into one? Once that is pushed, I'll reauthrorize running unittests and once they come back clean, I'd merge. |
…tml and css language embedding
c65b02d to
311ae06
Compare
Yes, the evolution can be added afterwards. Branch rebased and commits squashed. |
|
@haidubogdan thank you for your contribution. Merging. |
|
Hi @Chris2011 Unfortunately typescript doesn't have a classic language lexer, so it can't be used for a basic embedding. |
|
@haidubogdan thx for your info. TypeScript is using the generic textmate grammar registration and LSP functionality. Just a hint. I dunno what needs to be done to also add textmate lexers as embeddings. Maybe the embedding provider needs to be changed but this is a whole different topic. |
Basic coloring syntax support for javascript vue files
The pull request proposes a new Language for vue files with a coloring lexer implemented in Antlr.
At the current stage it also includes embedding support for Html & Css.
For javascript it will be just coloring embedding for the moment.
As learned from a previous pull request, maybe it's better to have simple merges for language support features.
In time, parser, completion, declaration finder features can be included as future updates, for which I can contribute.
More info about the template syntax can be found on their official site : https://vuejs.org/guide/essentials/template-syntax