Skip to content

Update nb-javac to jdk-24-ga.#8355

Merged
dbalek merged 1 commit intoapache:masterfrom
dbalek:dbalek/jdk-24-ga
Mar 21, 2025
Merged

Update nb-javac to jdk-24-ga.#8355
dbalek merged 1 commit intoapache:masterfrom
dbalek:dbalek/jdk-24-ga

Conversation

@dbalek
Copy link
Copy Markdown
Contributor

@dbalek dbalek commented Mar 20, 2025

Updating nb-javac to jdk-24-ga.

@dbalek dbalek added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Upgrade Library Library (Dependency) Upgrade labels Mar 20, 2025
@dbalek dbalek added this to the NB26 milestone Mar 20, 2025
@dbalek dbalek self-assigned this Mar 20, 2025
@dbalek dbalek added the nb-javac Run nb-javac integration tests label Mar 20, 2025
@dbalek dbalek mentioned this pull request Mar 20, 2025
Merged
@mbien
Copy link
Copy Markdown
Member

mbien commented Mar 20, 2025

doesn't look like there were any noteworthy changes:

git clone -b master https://github.com/openjdk/jdk24u.git
cd jdk24u/
git fetch --tags

git log --oneline jdk-24+29...jdk-24-ga -- src/java.compiler/ src/jdk.compiler/

a315b9326b0 8347498: JDK 24 RDP2 L10n resource files update
6965840e0dd 8347646: module-info classfile missing the preview flag
f0ada9f34e2 8345327: JDK 24 RDP1 L10n resource files update

still good that we switch to the ga release IMO.

@dbalek dbalek force-pushed the dbalek/jdk-24-ga branch from f8d2cb0 to 82b3c28 Compare March 20, 2025 14:34
@dbalek dbalek requested review from MartinBalin and lahodaj March 20, 2025 14:36
@dbalek dbalek removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Mar 20, 2025
MartinBalin
MartinBalin approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MartinBalin MartinBalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing nb-javac 24-GA build, as it will save us some questions in the future.

@lahodaj lahodaj removed the nb-javac Run nb-javac integration tests label Mar 21, 2025
@apache apache locked and limited conversation to collaborators Mar 21, 2025
@apache apache unlocked this conversation Mar 21, 2025
@dbalek dbalek merged commit dc7c5dc into apache:master Mar 21, 2025
71 of 72 checks passed
@dbalek dbalek deleted the dbalek/jdk-24-ga branch March 21, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbien mbien mbien approved these changes

@MartinBalin MartinBalin MartinBalin approved these changes

@lahodaj lahodaj Awaiting requested review from lahodaj

Assignees

@dbalek dbalek

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Milestone

NB26

Development

Successfully merging this pull request may close these issues.

4 participants

@dbalek @mbien @MartinBalin @lahodaj