Skip to content

Persist size of git create and switch branch windows#8328

Merged
mbien merged 1 commit intoapache:masterfrom
mbien:git-dialog-persistence
Mar 13, 2025
Merged

Persist size of git create and switch branch windows#8328
mbien merged 1 commit intoapache:masterfrom
mbien:git-dialog-persistence

Conversation

@mbien
Copy link
Copy Markdown
Member

@mbien mbien commented Mar 12, 2025

  • reuses the utility class from the revision selection window which already had that functionality
  • implemented for create and switch branch windows
  • refactored commit window to use the same utility

easiest way to access those windows (commit and create/switch branch) is via the git toolbar. The create-branch window has a select button which leads to the revision picker window. All 4 should persist their size now.

 - reuses the utility class from the revision selection window which
   already had that functionality
 - implemented for create and switch branch windows
 - refactored commit window to use the same utility
@mbien mbien added UI User Interface git [ci] enable versioning job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Mar 12, 2025
@mbien mbien added this to the NB26 milestone Mar 12, 2025
Copy link
Copy Markdown
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine; I tested it with the two dialogs and their size does appear persisted when the IDE is restarted. Thanks!

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Mar 13, 2025

ASF infra helped to get this repo unstuck, we have the correct merge button again. Will try to merge this one to check.

@mbien mbien merged commit d3ec3c2 into apache:master Mar 13, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) git [ci] enable versioning job UI User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants