Skip to content

apidoc html compliance part 2#8322

Merged
ebarboni merged 1 commit intoapache:masterfrom
ebarboni:apidocstructbulk2
Mar 13, 2025
Merged

apidoc html compliance part 2#8322
ebarboni merged 1 commit intoapache:masterfrom
ebarboni:apidocstructbulk2

Conversation

@ebarboni
Copy link
Copy Markdown
Contributor

this PR make the "stable" javadoc html compliant for jdk 23 javadoc.

There is a few modules left for being complete.

With this PR I added the template xslt change, to generate a table and reorder the headings. Some color taken from javadoc 23.

@ebarboni ebarboni added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Mar 12, 2025
@ebarboni ebarboni added this to the NB26 milestone Mar 12, 2025
@ebarboni ebarboni requested a review from mbien March 12, 2025 15:16
@mbien
Copy link
Copy Markdown
Member

mbien commented Mar 13, 2025

diffed the logs with master and overall this reduces the amount of warnings -> awesome!

there is one more link check failure though:

- [checklinks] /home/runner/work/netbeans/netbeans/nbbuild/build/javadoc/org-netbeans-modules-project-libraries/checklinks-errors-org-netbeans-modules-project-libraries.xml: 0 failures out of 1 tests
+ [checklinks] /home/runner/work/netbeans/netbeans/nbbuild/build/javadoc/org-netbeans-modules-project-libraries/checklinks-errors-org-netbeans-modules-project-libraries.xml: 1 failures out of 1 tests

With this PR I added the template xslt change, to generate a table and reorder the headings. Some color taken from javadoc 23.

can you add info like this to the commit message too? Might be useful when looking at the git blame history etc.

@ebarboni ebarboni force-pushed the apidocstructbulk2 branch from aac128a to 614d643 Compare March 13, 2025 15:44
@ebarboni
Copy link
Copy Markdown
Contributor Author

check failure is ok as previously it was a faulty @link not errored due to swallow of codesnippet.

Link is done via href and replace using @org-netbeans-modules-project-libraries-ui@ where the code is.

commit message changed

Copy link
Copy Markdown
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. please wait with merge until the asf.yaml problems are fixed

@ebarboni
Copy link
Copy Markdown
Contributor Author

as seems fixed I go for a merge

@ebarboni ebarboni merged commit 5739226 into apache:master Mar 13, 2025
31 checks passed
@ebarboni ebarboni deleted the apidocstructbulk2 branch March 14, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaDoc [ci] enable java/javadoc tests and build-javadoc target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants