Show dragged tab images at full HiDPI resolution#8310
Show dragged tab images at full HiDPI resolution#8310eirikbakke merged 3 commits intoapache:masterfrom
Conversation
…HiDPI resolution. Tested on MacOS with a Retina screen (2x scaling) and Windows 11 with 150% HiDPI scaling.
…. This commit makes no changes to the logic in DragWindow other than to set useFadeEffects to false and then simplify away all the resulting dead code and unused fields. Tidy up the code in a few places, without changing the logic.
183e079 to
64485a8
Compare
mbien
left a comment
There was a problem hiding this comment.
looks good (tested on linux/cinnamon). Nice cleanup.
I suppose lower powered systems like raspi could turn that feature off in the settings if the high quality rendering hints/buffer sizes cause problems. I vaguely remember that it had some stability issues a while ago, that is probably why I had it turned off in my workstation.
Replacing the JNA code with Java 7 window transparency API is something we could try in another cleanup at some point too.
|
Thanks for reviewing! Planning to merge without squashing since it's useful to have the "remove animation-related code" part in a separate commit.
I can have a look at it... |
|
@mbien I ended up adding another commit that removes the use of JNA, since it was easy to do. Tested on MacOS and Windows, both with the "Transparent drag window image" option (in Options->Appearance) both enabled and disabled. If you have a chance to test the latest version on Linux, that would cover all the OSes... thanks for your help! |
|
it doesn't work very well for me unfortunately (note the tab quality and the fact that the background rectangle isn't transparent) Lets not let the JNA cleanup distract from the original goal, we can add a cleanup at a later point and also deprecate |
ba96f7c to
fdddf58
Compare
|
@mbien Good catch; thanks for testing that! I have dropped the JNA removal commit then, restoring to the previous version you tried. I added one small change in a separate commit, which is a rectangle fill operation that turns out to be needed on Windows in non-transparent mode. I've tested it again on Windows and MacOS, in light and dark mode, and with and without transparency enabled. I'll squash this last commit into the previous before merging. |
…ix missing repaints when the dropEnabled indication is supposed to change.
fdddf58 to
5317a03
Compare
|
Squashed to leave 3 commits in the end before merging. |
|
@eirikbakke please pause merges for now, see dev list. |
|
@mbien Yes, saw that, will step away from the keyboard :-) Thank you for looking into it! |
When dragging window system tabs, show the dragged tab image at full HiDPI resolution.
Before:
After:
Tested on MacOS with a Retina screen (2x scaling) and Windows 11 with 150% HiDPI scaling.