Code scanner and search should tolerate CoderMalfunctionErrors#8304
Merged
mbien merged 1 commit intoapache:masterfrom Mar 8, 2025
Merged
Code scanner and search should tolerate CoderMalfunctionErrors#8304mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
note that multi-line search uses different code paths ( |
matthiasblaesing
approved these changes
Mar 7, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Only eyeballed this, but the screenshot looks good, the same goes for the change to code.
I have left a minor comment inline, but that does not block merging.
I think the real problem lies deeper, but last time I looked into this, I went out without a clear conclusion, so I think this improves things.
Thank you.
- scanner will skip the file and log a warning - search will add it to the regular search result error list cleanup - removed unused UI component - simplified exception handling in Source#createSnapshot
9efef6d to
e45a181
Compare
matthiasblaesing
approved these changes
Mar 8, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Thank you looks still sane 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup:
Source#createSnapshotindexer log:
fixes #3842
fixes #4354
fixes #4762
fixes #6671
fixes #7839