Merged
Conversation
mbien
reviewed
Mar 10, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
This is a PR out of 5 (I hope)
can you update commit and PR title to indicate what clusters/modules this covers if this is a multi-part PR?
Contributor
Author
|
it's 25 out of approx 140 modules in the javadoc build order (on master branch). It goes to ide folder and back to platform. Not sure how to present that. |
Member
|
well. give it a number at least, e.g: |
ce45887 to
a1a3077
Compare
Contributor
Author
|
roger |
mbien
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR out of 5 (I hope) where I execute the apidoc not using codesnippet-doclet.
javadoc 23 is checking hard for correct header sequence, removed attribute and element, and if an error is detected it break generation for the current module.
I would like to anticipate and having apidoc base clean to this aspect so I could focus on xslt management to get jdk23 looking docs later.
As header sequence changed I added more header to the link checker.
With default apidoc pages like https://bits.netbeans.org/dev/javadoc/org-netbeans-api-visual/org/netbeans/api/visual/widget/doc-files/documentation.html that render out of structure looks a bit better integrated: