Skip to content

remove NBI related modules and engine in code base#8283

Merged
ebarboni merged 2 commits intoapache:masterfrom
ebarboni:nbiclean
Apr 15, 2025
Merged

remove NBI related modules and engine in code base#8283
ebarboni merged 2 commits intoapache:masterfrom
ebarboni:nbiclean

Conversation

@ebarboni
Copy link
Copy Markdown
Contributor

Remove of modules that need nbi in the codebase.
Remove the nbi folder.

Adapt clusters to build.

@ebarboni ebarboni added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes. labels Feb 28, 2025
@mbien
Copy link
Copy Markdown
Member

mbien commented Feb 28, 2025

enabling all tests to have the build-from-source jobs running and lsp etc. This shouldn't have the Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes. label otherwise it won't appear in the release notes once merged.

@mbien mbien added Platform [ci] enable platform tests (platform/*) installer ci:all-tests [ci] enable all tests and removed Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes. labels Feb 28, 2025
@ebarboni
Copy link
Copy Markdown
Contributor Author

thanks, feel free to "amend" in case you wanna test things.

@apache apache locked and limited conversation to collaborators Feb 28, 2025
@apache apache unlocked this conversation Feb 28, 2025
@mbien mbien linked an issue Feb 28, 2025 that may be closed by this pull request
@mbien mbien removed the ci:all-tests [ci] enable all tests label Feb 28, 2025
@ebarboni
Copy link
Copy Markdown
Contributor Author

do you think removal of nbbuild/installer could make sense too ?

@mbien
Copy link
Copy Markdown
Member

mbien commented Mar 24, 2025

Even though there is no particular rush to remove NBI code itself, it is probably easier to do this right away instead of excluding it from the sources in other ways. So I am +1 for NB 26 unless some problem shows up.

As @neilcsmith-net mentioned on slack we will probably have to check some UI options (checkboxes etc) to make sure that they are gone too.

@neilcsmith-net
Copy link
Copy Markdown
Member

do you think removal of nbbuild/installer could make sense too ?

Yes, probably a good idea. Possibly some / all of nbbuild/newbuild too?

@mbien mbien added this to the NB26 milestone Mar 25, 2025
@mbien mbien added the ci:all-tests [ci] enable all tests label Apr 9, 2025
@mbien
Copy link
Copy Markdown
Member

mbien commented Apr 9, 2025

proposal for the nb application (maven) installer panel:
image

@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Apr 9, 2025
little late, but this does also turn pack200 off by default
@mbien
Copy link
Copy Markdown
Member

mbien commented Apr 9, 2025

enabled all tests, dev-build, rebased and added a commit with the changes visible in the screenshot above. (eric gave me his ok for this via slack)

@ebarboni
Copy link
Copy Markdown
Contributor Author

I undraft , do you think we miss some menu ?

@mbien
Copy link
Copy Markdown
Member

mbien commented Apr 11, 2025

I undraft , do you think we miss some menu ?

i couldn't find more but I haven't looked for very long. Wasn't there once a wizard which created branded installer panels or something like that? The ant project didn't have any deeper integration?

@ebarboni
Copy link
Copy Markdown
Contributor Author

maybe on ant netbeans platform project but I cannot create module project with ant

@ebarboni ebarboni marked this pull request as ready for review April 14, 2025 11:01
Copy link
Copy Markdown
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasta la vista NBI

@ebarboni ebarboni merged commit 1d08f46 into apache:master Apr 15, 2025
41 checks passed
@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Apr 15, 2025
@mbien mbien mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) installer Platform [ci] enable platform tests (platform/*)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NBI parent issue

3 participants