Skip to content

Permit relative paths and class names as 'mainClass' setting in launch.json.#8280

Merged
lahodaj merged 1 commit intoapache:masterfrom
lahodaj:relative-path-mainClass-in-launch-json
Mar 17, 2025
Merged

Permit relative paths and class names as 'mainClass' setting in launch.json.#8280
lahodaj merged 1 commit intoapache:masterfrom
lahodaj:relative-path-mainClass-in-launch-json

Conversation

@lahodaj
Copy link
Copy Markdown
Contributor

@lahodaj lahodaj commented Feb 27, 2025

Currently, if the launch.json contains mainClass, the value must be an absolute path. This patch adds the possibility to specify a relative path, or a (top-level) class name.

@lahodaj lahodaj added LSP [ci] enable Language Server Protocol tests VSCode Extension labels Feb 27, 2025
@lahodaj lahodaj added this to the NB26 milestone Feb 27, 2025
Copy link
Copy Markdown
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.
Do not forget to modify also the attribute description - see https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/package.json#L295

@lahodaj lahodaj force-pushed the relative-path-mainClass-in-launch-json branch from d35e058 to 744ccd3 Compare February 28, 2025 08:38
@lahodaj
Copy link
Copy Markdown
Contributor Author

lahodaj commented Feb 28, 2025

Fine. Do not forget to modify also the attribute description - see https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/package.json#L295

Thanks! Description updated (and force pushed).

@lahodaj lahodaj marked this pull request as ready for review February 28, 2025 08:40
@lahodaj lahodaj merged commit 9c40632 into apache:master Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LSP [ci] enable Language Server Protocol tests VSCode Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants