No wait cursor on CSL navigator expand#8274
Merged
lkishalmi merged 1 commit intoapache:masterfrom Mar 30, 2025
Merged
Conversation
mbien
reviewed
Feb 23, 2025
| elementView.setScrollOnExpand( scrollOnExpand ); | ||
| } | ||
| }); | ||
| elementView.setAutoWaitCursor(true); |
Member
There was a problem hiding this comment.
nothing against this but we should try to keep functionality in sync across the codebase.
the java navigator has the same disable/enable trick in the refresh method:
(there are no other usages looks like)
I think I can see the cursor change for a split second when I toggle collapse/expand in the java navigator.
Disabling the cursor change should be fine UX-wise, since the tree itself has a please-wait placeholder node for situations where it takes longer until the file structure is available.
b37b40b to
ead04d4
Compare
Contributor
Author
|
Removed the wait cursor form the Java Navigator, also from the Form Designer (Component Explorer), where everything shall be in memory anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, I find it a bit annoying, that almost every time I edit a Yaml, HCL file, there is a flickering on the mouse cursor changing to wait cursor and then back.
It turned out that is because the navigator is expanding it's tree to the current location, so when the structure changes it issues an expand and the
TreeView.autoWaitCursoristrueby default and put the cursor in wait mode for a brief moment.That led me to try other parts of the IDE, and expanding nodes could result with a brief mouse cursor change. That made me think to change the
TreeViewbehavior. It would be good to have the default for the wait cursor to befalse, though since it is down in the core I think it's being used many places outside of NetBeans.Probably the best would be delaying the wait cursor change by 500ms or so, and if the tree could expand it in that time we just do not do that. Might try to create a PR for that one, however for the default CSL provided navigator, I do not thing that we need the
autoWaitCursorfunctionality at all.