Remove maven 2 output parsing, cleanup and some parsing fixes#8265
Merged
mbien merged 1 commit intoapache:masterfrom Mar 13, 2025
Merged
Remove maven 2 output parsing, cleanup and some parsing fixes#8265mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
mbien
commented
Feb 21, 2025
| nextLine = line.substring(execEventIdx); | ||
| line = line.substring(0, execEventIdx); | ||
| } | ||
| if (line.startsWith("[INFO] Final Memory:")) { //NOI18N |
Member
Author
Member
There was a problem hiding this comment.
Yes, this is not logged anymore
ffca65f to
da236cc
Compare
da236cc to
73fb802
Compare
matthiasblaesing
approved these changes
Mar 12, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you.
I left some comments inline, you might want to have a look at, but nothing, that would stop integration.
- remove maven 2 specific output parsing - fix reactor summary parsing - disabled JavadocOutputProcessor since it doesn't do anything atm - OutputListener has now no-op default methods - code cleanup
73fb802 to
961ab95
Compare
matthiasblaesing
approved these changes
Mar 13, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Only eyeballed, but looks like a nice cleanup. I did not have this in mind, but thanks anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavadocOutputProcessorsince it doesn't do anything atmOutputListener)reactor summary link on failure is working again (useful with
--fail-at-end):