Attempting to fix code completion after new HashMap<>#8237
Merged
lahodaj merged 1 commit intoapache:masterfrom Feb 21, 2025
Merged
Attempting to fix code completion after new HashMap<>#8237lahodaj merged 1 commit intoapache:masterfrom
lahodaj merged 1 commit intoapache:masterfrom
Conversation
Member
|
quickly checked for regressions since the last completion chaining fix #4165 and everything appeared to still work fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider code like:
In VS Code, selecting e.g. the
HashMap()option will repeatHashMaphere. Inside the NetBeans UI, this will not happen, but<tab>will still insertHashMap.This is an attempt to avoid these problems, by recording the completion appeared after the
<>, and not inserting the name. Not sure if this is the best solution, though.