Merged
Conversation
mbien
reviewed
Feb 11, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
Hi @makiam the update looks good but this repo requires the real name on the commits (account name is not enough).
you can check it on https://github.com/apache/netbeans/pull/8234.patch
git commit --amend --author="Author Name <email@address.com>" --no-edit
and then simply force push into the same branch of this PR
Signed-off-by: makiam <maxtemplaar@gmail.com>
9dfa11d to
9e75556
Compare
Contributor
Author
|
Commit author name fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improwe Swing GUI templates:
Use multicatch in LookAndFeel initialization code.
Replace new Runnable() ... with lambda call
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.