Fix database properties directory#8222
Merged
MartinBalin merged 1 commit intoapache:masterfrom Mar 5, 2025
Merged
Conversation
MartinBalin
approved these changes
Feb 17, 2025
Contributor
MartinBalin
left a comment
There was a problem hiding this comment.
Looks good and tested with 2 projects and userdir Global/Local. Files are created in tmp folder and removed when Debug session ends.
7274ee1 to
4d6d272
Compare
thurka
reviewed
Feb 24, 2025
thurka
reviewed
Feb 24, 2025
|
|
||
| private Path generateConfigFile() throws IOException { | ||
| Path dir = generateDirPath(); | ||
| private Path generateConfigFile() throws IOException { |
Contributor
There was a problem hiding this comment.
Please avoid white-space changes. They make review more dificult.
thurka
requested changes
Feb 24, 2025
Contributor
thurka
left a comment
There was a problem hiding this comment.
The java part have some minor issues, otherwise it looks good.
4d6d272 to
58bb84a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scpcommand (one handshake)run-containerscript in handlebar template