Versioning: don't wait for indexer before refresh#8202
Merged
mbien merged 2 commits intoapache:masterfrom Apr 15, 2025
Merged
Conversation
830c9e3 to
23b04a0
Compare
23b04a0 to
ce8ef50
Compare
ce8ef50 to
5780bd4
Compare
Member
Author
|
planning to merge this for NB 26, this PR had also a dev mail thread |
- indexing and versioning status updates can run concurrently since they don't interact with each other. - git status refresh typically takes < 1s even in large projects. indexing can take much longer. fix and performance: - refresh versioning annotations on project open otherwise they might be missing on re-open until the tree is expanded - lock-free CacheIndex#get(file)
5780bd4 to
54231a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexing and versioning status updates can run concurrently since they don't interact with each other.
git status refresh typically takes < 1s even in large projects, while indexing can take much longer.
bonus changes:
CacheIndex#getcan run lock free given that the index is a CHM and the values are synchronized Setsexpected results:
old behavior can be restored with
-J-Dversioning.delayscan=truecleanup commit is split from the change