Skip to content

Release candidates should not steal the maven index from GA releases#8199

Merged
ebarboni merged 1 commit intoapache:deliveryfrom
mbien:no-index-import-into-rc
Feb 4, 2025
Merged

Release candidates should not steal the maven index from GA releases#8199
ebarboni merged 1 commit intoapache:deliveryfrom
mbien:no-index-import-into-rc

Conversation

@mbien
Copy link
Copy Markdown
Member

@mbien mbien commented Jan 27, 2025

lets not move the index from NB 24 -> 25-rcN when testing new releases. This would only cause NB 24 to download it again which is unnecessary.

(if this happened to you you can simply move it back to the 24 cache. Setting -J-Dmaven.indexing.diag.release=0 will also prevent it)

targets delivery

@mbien mbien added the Maven [ci] enable "build tools" tests label Jan 27, 2025
@mbien mbien added this to the NB25 milestone Jan 27, 2025
@neilcsmith-net
Copy link
Copy Markdown
Member

Looks good. Slightly concerned at proliferation of code that relies on specifics of our versioning scheme. The next time we need that, something to possibly considering abstracting into Places and/or a way to mark prereleases with a file similar to lastUsedVersion.

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jan 27, 2025

Looks good. Slightly concerned at proliferation of code that relies on specifics of our versioning scheme.

yes, we have several instances were it would be useful to query the NB version etc (nb version, javac versions #3274).

But this here is just a "best effort" mechanism and version is just one attribute to probe for, the other are time stamps etc. If this fails it fails quietly and is no show stopper.

The next time we need that, something to possibly considering abstracting into Places..

yep!

@ebarboni ebarboni self-requested a review February 3, 2025 17:19
Copy link
Copy Markdown
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebarboni ebarboni merged commit 4b3bfa3 into apache:delivery Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maven [ci] enable "build tools" tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants