Don't add the listener if a document is not a test file#8196
Merged
ebarboni merged 1 commit intoapache:deliveryfrom Jan 28, 2025
Merged
Don't add the listener if a document is not a test file#8196ebarboni merged 1 commit intoapache:deliveryfrom
ebarboni merged 1 commit intoapache:deliveryfrom
Conversation
junichi11
commented
Jan 26, 2025
php/php.project/src/org/netbeans/modules/php/project/ComputeTestMethodAnnotations.java
Outdated
Show resolved
Hide resolved
php/php.project/src/org/netbeans/modules/php/project/ComputeTestMethodAnnotations.java
Show resolved
Hide resolved
tmysik
reviewed
Jan 26, 2025
php/php.project/src/org/netbeans/modules/php/project/ComputeTestMethodAnnotations.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Jan 26, 2025
Member
tmysik
left a comment
There was a problem hiding this comment.
@junichi11 , please, see my comments, thank you.
eb40f84 to
b4fcdad
Compare
tmysik
approved these changes
Jan 26, 2025
- Avoid adding the listener to all PHP files (Add it to only test files) Because other than test files don't have test methods - Improve the deeply nested parts
b4fcdad to
c6eb9a8
Compare
troizet
approved these changes
Jan 26, 2025
Collaborator
troizet
left a comment
There was a problem hiding this comment.
Thank you very much for the improvements!
Member
Author
|
I made an elementary stupid mistake but I realized that thanks to Tomas. |
Member
Author
Contributor
|
will merge this and create sync but the #8201 will need rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.