Skip to content

Improve support for Jakarta EE 11#8182

Merged
ebarboni merged 1 commit intoapache:masterfrom
pepness:gf-jakartaee11
Jan 24, 2025
Merged

Improve support for Jakarta EE 11#8182
ebarboni merged 1 commit intoapache:masterfrom
pepness:gf-jakartaee11

Conversation

@pepness
Copy link
Copy Markdown
Member

@pepness pepness commented Jan 22, 2025 •
edited
Loading

NetBeans Notes:

  • Add missing Jakarta EE 11 constant for GlassFish module

NetBeans Testing:

  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of Verify Sigtests
  • Verify successful execution of unit tests for modules glassfish.common, glassfish.javaee, glassfish.tooling, and glassfish.eecommon
  • Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
  • Successfully register GlassFish 8.0.0-M9
    • Create a Jakarta EE 11 maven web app and verify that it works
    • Create a Jakarta EE 11 ant web app and verify that it works.

@pepness pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Jan 22, 2025
@pepness pepness added this to the NB25 milestone Jan 22, 2025
@pepness pepness self-assigned this Jan 22, 2025
@mbien
Copy link
Copy Markdown
Member

mbien commented Jan 23, 2025

isn't JDK 17 still supported? https://jakartaee.github.io/platform/jakartaee11/JakartaEE11ReleasePlan

@pepness
Copy link
Copy Markdown
Member Author

pepness commented Jan 23, 2025

I was under the impression that the minimum Java SE version would be 21, with GlassFish Java SE 17 is only intended for TCK purposes, for the final release of GlassFish 8, JDK 21 is required as a minimum.

But the latest specification clearly requires v17 o later. I will revert that maven artifact again, thanks @mbien.

@mbien
Copy link
Copy Markdown
Member

mbien commented Jan 23, 2025

will this constant do anything all by itself? It doesn't have to be registered in an enum or something like that?

@ebarboni
Copy link
Copy Markdown
Contributor

ebarboni commented Jan 24, 2025

merging this,

@ebarboni ebarboni merged commit 340da06 into apache:master Jan 24, 2025
@euasier euasier mentioned this pull request Aug 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbien mbien mbien approved these changes

Assignees

@pepness pepness

Labels

enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job

Projects

None yet

Milestone

NB25

Development

Successfully merging this pull request may close these issues.

3 participants

@pepness @mbien @ebarboni