Add support for PHPStan error identifiers#8170
Merged
KacerCZ merged 1 commit intoapache:masterfrom Jan 19, 2025
Merged
Conversation
PHPStan since version 1.11 uses identifiers for errors. Error identifers are read and displayed with this change. Reference: https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers
junichi11
approved these changes
Jan 18, 2025
Member
junichi11
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for your work!
Can you attach a screenshot?
Contributor
Author
|
Thanks for the review. |
Member
|
Thanks! Please attach it to the above description because someone may look at this change after NB25 is released. (Also before one if possible.) |
Contributor
Author
|
Changed screenshot and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan since version 1.11 uses identifiers for errors.
Error identifiers are read and displayed with this change.
Reference: https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers
Before:
After:
