Skip to content

typescript: Fix location of binaries#8168

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:fix_location_typescript
Jan 17, 2025
Merged

typescript: Fix location of binaries#8168
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:fix_location_typescript

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Contributor

Fix for 9fe66a3

@matthiasblaesing matthiasblaesing added TypeScript [ci] enable web job Regression This used to work! labels Jan 17, 2025
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Jan 17, 2025
Copy link
Copy Markdown
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. hashes remained the same and I see the files on osuosl.

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

@mbien thanks for review + heads-up. I had local copies, which made it easy to fix. I intent to merge once green.

@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

FWIW I temporarily restored the files to their old location. That should help currently open PRs.

@matthiasblaesing matthiasblaesing merged commit 1b6b4f8 into apache:master Jan 17, 2025
@mbien
Copy link
Copy Markdown
Member

mbien commented Jan 17, 2025

FWIW I temporarily restored the files to their old location. That should help currently open PRs.

cool! github has it all in the cache so it wouldn't be affected. I only noticed this issue when I tried to build locally on a different machine which didn't have a cache yet.

@matthiasblaesing matthiasblaesing deleted the fix_location_typescript branch March 5, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Regression This used to work! TypeScript [ci] enable web job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants