Persist tab order on per-project basis between close/open.#8164
Merged
mbien merged 1 commit intoapache:masterfrom Jan 19, 2025
Merged
Persist tab order on per-project basis between close/open.#8164mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
eirikbakke
reviewed
Jan 19, 2025
eirikbakke
reviewed
Jan 19, 2025
- changed to collections which retain entry order - refresh storage on close if order changed note: opened files are stored per project, re-opening multiple projects will restore the right order within the project but they will be sorted by project as side effect. opened projects might not have a specific order since they come right from the lookup.
9d282c1 to
6225b37
Compare
eirikbakke
approved these changes
Jan 19, 2025
Member
Author
|
thanks for review. going to merge since I found an ergonomics related NPE in the same area which can be fixed in a followup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note:
fixes #4416