Add support for GlassFish 7 up to 7.0.21, and GlassFish 8 up to 8.0.0-M9#8153
Add support for GlassFish 7 up to 7.0.21, and GlassFish 8 up to 8.0.0-M9#8153pepness merged 1 commit intoapache:masterfrom
Conversation
GlassFish 8.0.0-M9
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Inline I added one comment for future updates and one question. Both don't hold of merging.
There was a problem hiding this comment.
For the future I don't think these changes are necessary. They don't test the version, just the eh operators work. That is independend on newer versions.
| public void testGetInstanceforVersionGF7() { | ||
| GlassFishServerEntity srv = new GlassFishServerEntity(); | ||
| srv.setVersion(GlassFishVersion.GF_7_0_15); | ||
| srv.setVersion(GlassFishVersion.GF_7_0_21); |
There was a problem hiding this comment.
What is the intention of this change?
There was a problem hiding this comment.
Those test are helpful in my pipeline, sometimes I messed up ServerDetails, registering the wrong ConfigBuilderProvider or even working on a different branch. I always run the unit test for the 4 GlassFish modules using the latest version that I add support to. That is why I always change the version of the unit tests.
NetBeans GlassFish module notes:
NetBeans Testing:
glassfish.common,glassfish.javaee,glassfish.tooling, andglassfish.eecommonRelease Notes for GlassFish 7
Release Notes for GlassFish 8