Cleanup the few remaining HashSet warnings.#8147
Merged
BradWalker merged 1 commit intoapache:masterfrom Jan 14, 2025
Merged
Conversation
Reduce warnings that look like this: [repeat] /home/bwalker/src/netbeans/enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java:144: warning: [rawtypes] found raw type: HashSet [repeat] private final Set<String> targetsStartedByIde = new HashSet(); // valued by target name [repeat] ^ [repeat] missing type arguments for generic class HashSet<E> [repeat] where E is a type-variable: [repeat] E extends Object declared in class HashSet
matthiasblaesing
approved these changes
Jan 13, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Please fix your name in the author commit header. One can read you real name from it, but it still should be just a full name.
Member
has 4 variants and the one without space is already there, so its probably fine ;) (but you should fix it anyway!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup the few remaining HashSet warnings.. Reduce warnings that look like this:
[repeat] /home/bwalker/src/netbeans/enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java:144: warning: [rawtypes] found raw type: HashSet
[repeat] private final Set targetsStartedByIde = new HashSet(); // valued by target name
[repeat] ^
[repeat] missing type arguments for generic class HashSet
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class HashSet
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.