csl.api: Fix wrong @NonNull annotation in methods of Language#8146
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Jan 15, 2025
Merged
csl.api: Fix wrong @NonNull annotation in methods of Language#8146matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing merged 1 commit intoapache:masterfrom
Conversation
The methods: - getOccurrencesFinder - getSemanticAnalyzer - getIndexSearcher - getOverridingMethods can return null, if the implemention does not provide these services. The @nonnull annotation is thus wrong. As Language is not API the use-sites that relied on the non-null assertion were fixed and the annotations updated.
mbien
approved these changes
Jan 15, 2025
Member
mbien
left a comment
There was a problem hiding this comment.
makes sense. Quickly checked the usages too.
Contributor
Author
|
@mbien thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods:
can return null, if the implemention does not provide these services. The @nonnull annotation is thus wrong. As Language is not API the use-sites that relied on the non-null assertion were fixed and the annotations updated.