Payara Server instance running on WSL with deploy-on-save breaks "Web Application" Ant projects#8144
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. The problem described in the issue is not reproducible anymore, which hot deployment/copy on change still works with the payara server I registered. Thank you.
One thing I noticed while testing, was that the "Docker" and "WSL" toggles only work when creating a new server. I'm missing a toggle for these properties in the service change dialog. That problem is not introduced here, but you might consider fixing it here or in a followup.
|
@jGauravGupta dependent on how you want to merge this - don't forget to squash. Only mentioning it since we got merges recently where this was skipped and ~15 commits were merged by accident. |
… Application" Ant projects Revert distributeOnSave in DeployOnSaveManager Fixes application path to distribute file on save Tooltip for WSL and Docker WSL and Docker configuration in Payara Server Properties panel DeployOnSaveManager deprecated and available for older version (<2.2)
4143150 to
e43e28c
Compare
|
After the changes to problem is still fixed. "Instance Type" "None" sounds a bit strange for a normal installation. I think this can be merged. |
|
Sorry, @matthiasblaesing, I missed your comment regarding the "Instance Type" => "None" before the merge. I have created another PR to address the naming. I would greatly appreciate your suggestions. |
This pull resolves an issue where running a Payara Server instance on WSL breaks Java Web Application projects that use Ant in Apache NetBeans.
Changes in this PR:
distributeOnSaveinDeployOnSaveManagerimplementation to remove faulty path substring logic./mntto Windows system, with this fixorg.netbeans.modules.j2ee.deployment.impl.ServerFileDistributor#distributeOnSaveis correctly used.DeployOnSaveManageris deprecated for Payara Micro tools and only available for older version (<2.2). For newer version dev mode support is available by default.Reported issue: #8138
Discussion: #8121
Original PR: #7885