Fix race/error handling issues on NBLS restart.#8134
Merged
sdedic merged 1 commit intoapache:masterfrom Jan 15, 2025
Merged
Conversation
Member
Author
|
During further testing it occurred that the request to restart NBLS because of change Please review carefully. |
MartinBalin
approved these changes
Jan 10, 2025
petrovic-d
approved these changes
Jan 10, 2025
dbalek
approved these changes
Jan 14, 2025
…ple-start-avoidance
8d21c1a to
83f5757
Compare
Member
Author
|
Squashed before merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing, it turned out that when NBLS is enabled "fast enough" after extension start, the extension may not initialize properly.
There are surely more bugs ;)) but the ones most prominent are:
In addition, if the client is stop()ped during/soon after restart, the Explorer (project view, database view or cloud assets) attemp to communicate with a dead client, which results in error notifications.