Merged
Conversation
4d32e4a to
3672060
Compare
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
This PR contains changes, that don't relate to the title (c615560 should not be here) these should be removed.
The fabric8 license looks good to me. Neither in the JARs, nor in the repository a NOTICE file is visible. The same is true for the three dependencies from okhttp.
Looking at the dependency what I see:
- The version of the library was already obsolete when it was added. 6.13.4 was current when the library as added. Please update.
- There is
kubernetes-httpclient-jdkas an alternative tokubernetes-httpclient-okhttp, the former using the JDKs http client, reducing the footprint a bit.
Contributor
There was a problem hiding this comment.
Name should be fabric8-6.7.0-license.txt (the version number in the license file should match the version of the target library. For single jars this is enforced.
9336ac0 to
a1fe017
Compare
a1fe017 to
dbcaa13
Compare
Member
Author
|
matthiasblaesing
approved these changes
Jan 10, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you.
sdedic
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing license files for Fabric8 library