Skip to content

Fix nanoid and revert default VSIX version#8047

Merged
MartinBalin merged 1 commit intoapache:masterfrom
MartinBalin:master
Dec 16, 2024
Merged

Fix nanoid and revert default VSIX version#8047
MartinBalin merged 1 commit intoapache:masterfrom
MartinBalin:master

Conversation

@MartinBalin
Copy link
Copy Markdown
Contributor

Fix nanoid npm version to 3.3.8 due to GHSA-mwcw-c2x4-8c55 keeping mocha version the same. Revert back default VSIX version to 0.1.0.

@MartinBalin MartinBalin self-assigned this Dec 13, 2024
@MartinBalin MartinBalin added this to the NB25 milestone Dec 13, 2024
@MartinBalin MartinBalin merged commit 5244f73 into apache:master Dec 16, 2024
@sdedic
Copy link
Copy Markdown
Member

sdedic commented Dec 16, 2024

@mbien could you please help me to understand why the paperwork failed ? The error message reads:

Error: PRs must be labeled, see: https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide

and as I can see the script checks that at least one label is present on the PR. This PR was labelled 'VSCode Extension' before the tests were re-run today. What went wrong ?

@apache apache locked and limited conversation to collaborators Dec 16, 2024
@apache apache unlocked this conversation Dec 16, 2024
@neilcsmith-net
Copy link
Copy Markdown
Member

neilcsmith-net commented Dec 16, 2024

@sdedic this is likely the PR was labelled after opening? In which case use the lock/unlock trick to get the labels picked up on a new run. Re-running a workflow uses the same original cached state of the PR when triggered, such as the labels.

@MartinBalin
Copy link
Copy Markdown
Contributor Author

This is the case I usually add labels when PR is created.

@mbien
Copy link
Copy Markdown
Member

mbien commented Dec 16, 2024

and as I can see the script checks that at least one label is present on the PR. This PR was labelled 'VSCode Extension' before the tests were re-run today. What went wrong ?

@sdedic this section on the guide describes the detail

If the labels are changed you need a fresh workflow run. This can be done via a regular PR sync event (branch changes). The lock/unlock trick was added for situations when reviewers have to change labels of non-committers. But it ended up being also useful for reviewers which wanted to add more jobs to the PR without having to ping someone.

If everything was labeled before the PR was created then this might have been a github bug - I don't know. Please check that the right jobs run right before pressing merge! If something doesn't look right - do a rebase and it will also start a fresh workflow run.

@mbien
Copy link
Copy Markdown
Member

mbien commented Dec 16, 2024

Btw checking that the right jobs ran is part of our approval process too.

approval and merge check lists:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRapprovalchecklist

@sdedic
Copy link
Copy Markdown
Member

sdedic commented Dec 16, 2024

Btw checking that the right jobs ran is part of our approval process too.

Point taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants