Fix ugly semantic coloring on CSL languages while editing#8018
Merged
lkishalmi merged 1 commit intoapache:masterfrom Dec 5, 2024
Merged
Fix ugly semantic coloring on CSL languages while editing#8018lkishalmi merged 1 commit intoapache:masterfrom
lkishalmi merged 1 commit intoapache:masterfrom
Conversation
matthiasblaesing
approved these changes
Dec 5, 2024
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
To my understanding dropping the Math.min with nextElementStartOffset makes sense as the ranges end is shifted according to the edits, while nextElementStartOffset is not updated and held at the original offset.
For the followup commit nextElementStartOffset can be removed as it is not used anymore and thus the updateNextElementStartOffset method can be simplified.
Contributor
Author
|
Yes. This will be simplified in the upcoming PR, where I'm addressing the issues in the |
Member
|
@lkishalmi I updated the PR text with the first paragraph of the other PR which included the videos. So that it is easier to parse when accessed from the release notes. Please check that everything is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is bugging me for years.
Whenever I insert or write text to a CSL based editor the semantic coloring does not keep track with the document change
and some text elements get discolored as you type. The next parsing run would then set the colors right.
See the discoloration of
permissionsbefore:Screencast From 2024-12-01 13-04-47.webm
After this fix:
Screencast From 2024-12-01 13-07-58.webm
This one would supersede #8011 contains the fix only. The rest of the code changes will be in a separate PR.