Handling Diagnostics with start position -1 while writing error/warning index.#7998
Closed
dbalek wants to merge 1 commit intoapache:masterfrom
Closed
Handling Diagnostics with start position -1 while writing error/warning index.#7998dbalek wants to merge 1 commit intoapache:masterfrom
dbalek wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
While I think this is probably a good solution, unless the original change is very important, I would suggest to go with Michael's proposal, and revert the original change (+the hotfix) from NetBeans 24, and re-apply to master. |
Member
Member
|
I think reverting both PRs #7981 (comment) might work without having to resolve conflicts. We should avoid working on those files until this is resolved if possible - otherwise syncs back to master will cause unnecessary conflicts and/or PRs might show up multiple times on release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition to the #7983 to handle also Diagnostics with start position -1.