Fix possible out of bounds exception in switch pattern hint#7973
Merged
mbien merged 1 commit intoapache:masterfrom Nov 19, 2024
Merged
Fix possible out of bounds exception in switch pattern hint#7973mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Nice catch. Overall, I agree with the solution, although having a test would be good. Also, we could consider making the code a little bit more understandable, e.g.: |
- index can be less than 0 in some situations - added test and code simplification suggestions from Jan Lahoda Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
1c9e957 to
0fa77ff
Compare
Member
Author
|
applied the patch and added @lahodaj as co-author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index can be less than 0
found this issue while testing #7968
this (invalid) snippet:
will cause: