Tabcontrol: Use NbBundle to fetch correct translation#7970
Merged
matthiasblaesing merged 2 commits intoapache:masterfrom Nov 18, 2024
Merged
Tabcontrol: Use NbBundle to fetch correct translation#7970matthiasblaesing merged 2 commits intoapache:masterfrom
matthiasblaesing merged 2 commits intoapache:masterfrom
Conversation
mbien
approved these changes
Nov 16, 2024
Member
mbien
left a comment
There was a problem hiding this comment.
makes sense. Both TabbedContainer and TabDisplayer in the same module use NbBundle already. So the ResourceBundle might have been a mistake there.
|
Hi Matthias, |
Contributor
Author
|
@mbien thanks for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7950