Improving Java code completion support for sealed types in switches.#7966
Merged
lahodaj merged 1 commit intoapache:masterfrom Dec 2, 2024
Merged
Conversation
dbalek
approved these changes
Nov 18, 2024
dbalek
approved these changes
Nov 27, 2024
effe121 to
c4a0e1b
Compare
c4a0e1b to
bbdc51e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider code like:
The (Java) code completion returns all types at the specified place, instead of just subtypes of
i. This patch is trying to solve that, by using the selector's type as a base type, and hence only proposing the correct subclasses/interfaces.The patch is sadly a bit biggish, partly as it seems I need to add
smartTypeflag tocreateStaticMemberItem. The code is also tricky around qualified enum constants (which are permitted since JDK 21).There may be further improvements possible, but I hope this PR leads to a not completely unreasonable state.